Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fabric issues #1485

Merged
merged 4 commits into from
Jun 22, 2022
Merged

fix: fabric issues #1485

merged 4 commits into from
Jun 22, 2022

Conversation

WoLewicki
Copy link
Member

PR adding missing onNativeDismissCancelled prop, moving RNSScreenView resolving logic to a new prop in RNSScreen, and fixing snapshotting mechanism issues.

Test code and steps to reproduce

Various test cases in FabricTestExample.

Checklist

@WoLewicki WoLewicki marked this pull request as ready for review June 21, 2022 14:31
@kkafar kkafar merged commit bc234d7 into main Jun 22, 2022
@kkafar kkafar deleted the @wolewicki/fix-fabric-issues branch June 22, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WoLewicki @kkafar