Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adds common problems section to README #1156

Merged
merged 4 commits into from
Oct 21, 2021
Merged

chore: Adds common problems section to README #1156

merged 4 commits into from
Oct 21, 2021

Conversation

Ubax
Copy link
Contributor

@Ubax Ubax commented Sep 28, 2021

Description

Adds common problems section to README

Checklist

@Ubax Ubax marked this pull request as ready for review October 19, 2021 06:57
WoLewicki
WoLewicki reviewed Oct 19, 2021
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments regarding the second section.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Ubax Ubax requested a review from WoLewicki October 20, 2021 07:01
@Ubax Ubax merged commit 1f84549 into master Oct 21, 2021
@Ubax Ubax deleted the @ubax/add-common-problems-to-readme branch October 21, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kacperkapusciak kacperkapusciak kacperkapusciak approved these changes

@WoLewicki WoLewicki Awaiting requested review from WoLewicki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ubax @WoLewicki @kacperkapusciak