-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async -> sync #1006
Closed
Closed
async -> sync #1006
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
import React, { useEffect } from 'react'; | ||
import { View, Text } from 'react-native'; | ||
import { createStackNavigator } from '@react-navigation/stack'; | ||
import { NavigationContainer } from '@react-navigation/native'; | ||
const levels = 2; | ||
const Stack = createStackNavigator(); | ||
|
||
function RandomStack(props: any) { | ||
const {navigation, route, level} = props; | ||
|
||
if (level === 0) { | ||
console.log("level props", level, Object.keys(route)); | ||
return ( | ||
<View> | ||
<Text> {"level route " + level + " " + route.name} </Text> | ||
</View> | ||
); | ||
} | ||
if (false && level != levels) { | ||
const isFocused = navigation.isFocused(); | ||
useEffect(() => { | ||
if (isFocused) { | ||
const stay = Math.random() < 0.9; | ||
const next = Math.round(Math.random() * 99) % 3; | ||
const sib = stay ? route.name : next.toString(); | ||
navigation.navigate( | ||
sib, | ||
); | ||
} | ||
}, [isFocused]); | ||
} | ||
|
||
return ( | ||
<Stack.Navigator> | ||
<Stack.Screen name="0" > | ||
{ (props) => <RandomStack {...props} level={level-1}/> } | ||
</Stack.Screen> | ||
<Stack.Screen name="1" > | ||
{ (props) => <RandomStack {...props} level={level-1}/> } | ||
</Stack.Screen> | ||
<Stack.Screen name="2" > | ||
{ (props) => <RandomStack {...props} level={level-1}/> } | ||
</Stack.Screen> | ||
</Stack.Navigator> | ||
); | ||
} | ||
|
||
export default function NestedStacksExample() { | ||
return ( | ||
<NavigationContainer> | ||
<RandomStack level={levels} /> | ||
</NavigationContainer> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to no longer be necessary if we create new transaction and then commit it with each single operation. As a consequence we wouldn't need the
mCurrentTransaction
field nor need to call getOrCreaeTransaction nor tryCommitTransactionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was left for usage with
ScreenStack
, where we have animations inFragments
, so we want to concatenate all the operations into one and run animations on them. Btw, I would change the namecommitNowAllowingStateLoss
to something likecommitTransaction
.