TVOS does not support dark appearance #2222
Assignees
Labels
Platform: tvOS
Issue related with tvOS compatibility
Repro provided
A reproduction with a snack or repo is provided
Comments
|
Hey! 👋 The issue doesn't seem to contain a minimal reproduction. Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem? |
alduzy
added
Repro provided
1 task
alduzy
added a commit
that referenced
this issue
Jul 15, 2024
## Description This PR intents to fix navigation bar appearance customization on tvOS. Now it's impossible to customize the navigation bar on tvOS. The options, such as `headerTintColor` are not applied at all and the defaults are making it hard to read when the appearance is set to `dark` on the device: - title text color defaults to white - backgroundColor of modal screens header defaults to dark gray In current implementation the appearance is set on the navigationItem, like this: `navigationItem.standardAppearance = appearance`. Out of curiosity I tried setting the appearance on navigationBar as found in [this article](https://developer.apple.com/documentation/uikit/uinavigationcontroller/customizing_your_app_s_navigation_bar?language=objc), like this: `navigationBar.standardAppearance = appearance` and I got following error: `New Bar Appearance API is not supported on this version of tvOS. Use legacy customization`. Looks like the `UINavigationBarAppearance` does not work for us although it should be fine on tvOS 13+ according to the [docs](https://developer.apple.com/documentation/uikit/uinavigationbarappearance?language=objc). I found using the [legacy customizations](https://developer.apple.com/documentation/uikit/uinavigationbar/legacy_customizations?language=objc) to be the only working solution. Fixes #2222 ## Changes - updating appearance manually for tvOS ## Screenshots / GIFs | `before` | `after` | |--------|--------| |  |  | |  |  | ## Test code and steps to reproduce - Use the `TVOSExample` - Toggle light/dark appearance on the device - Customize header options, such as `headerTintColor` ## Checklist - [x] Ensured that CI passes
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this issue
Oct 9, 2024
## Description This PR intents to fix navigation bar appearance customization on tvOS. Now it's impossible to customize the navigation bar on tvOS. The options, such as `headerTintColor` are not applied at all and the defaults are making it hard to read when the appearance is set to `dark` on the device: - title text color defaults to white - backgroundColor of modal screens header defaults to dark gray In current implementation the appearance is set on the navigationItem, like this: `navigationItem.standardAppearance = appearance`. Out of curiosity I tried setting the appearance on navigationBar as found in [this article](https://developer.apple.com/documentation/uikit/uinavigationcontroller/customizing_your_app_s_navigation_bar?language=objc), like this: `navigationBar.standardAppearance = appearance` and I got following error: `New Bar Appearance API is not supported on this version of tvOS. Use legacy customization`. Looks like the `UINavigationBarAppearance` does not work for us although it should be fine on tvOS 13+ according to the [docs](https://developer.apple.com/documentation/uikit/uinavigationbarappearance?language=objc). I found using the [legacy customizations](https://developer.apple.com/documentation/uikit/uinavigationbar/legacy_customizations?language=objc) to be the only working solution. Fixes software-mansion#2222 ## Changes - updating appearance manually for tvOS ## Screenshots / GIFs | `before` | `after` | |--------|--------| |  |  | |  |  | ## Test code and steps to reproduce - Use the `TVOSExample` - Toggle light/dark appearance on the device - Customize header options, such as `headerTintColor` ## Checklist - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When trying the TVOSExample app with device's appearance set to
darki noticed the header title is almost invisible.There is a difference in how the modal header is presented as well. The app looks fine when used with appearance set to
light. It's worth noting I did not pass any extrathemetoNavigationContainer.Screenshots
lightdarkExpected behaviour
The app should not change it's look based on device's appearance until it is intended by passing theme to
NavigationContainer. That's how it works on iOS and android.Steps to reproduce
Snack or a link to a repository
https://github.com/software-mansion/react-native-screens/tree/main/TVOSExample
Screens version
3.32.0
React Native version
0.74.1
Platforms
tvOS
JavaScript runtime
None
Workflow
None
Architecture
None
Build type
None
Device
None
Device model
No response
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: