White flash on tab change with @react-navigation/bottom-tabs #1645
Comments
github-actions
bot
added
Repro provided
|
Hi @gkueny, would you mind confirming whether this issue appears on iOS 15.x? |
|
Hi @kkafar , I can confirm that I reproduce the issue in iOS 15.5 (simulator) |
|
Thank you, I'll look into this |
|
We're experiencing the same issue. Any update? |
|
@techgerm not on my end. I update the minimal reproduction repo with latest version of |
|
I get this issue as well. Wonder if it's related to this conversation where "flickering" is discussed? react-navigation/react-navigation#11285 |
|
Facing this same issue |
|
@kkafar has there been any moment on this issue so far? |
|
Curious about this also, same setup, ios, botom navigator and latest version of native screens |
|
I updated minimal reproduction with latest version of each lib & latest version of react-native : gkueny/native-stack-flash-issue-reproduction@46045f1 Issue is still present |
|
I can confirm the issue is reproducible on Paper architecture, Fabric works fine. |
This PR gets rid of undesired white flashes during `maybeAddToParentAndUpdateContainer`. The white flash was present on paper architecture when `unmountOnBlur` option was set to true on parent bottomStackNavigator (see repro). The affected logic was previously introduced or changed by following PRs: - #600 - #613 - #643 The removed `_hasLayout` was initially added by #600 in order to resolve an issue: #432. However the logic was later changed by #613 in order to fix another issue and the added `_hasLayout` may not fix anything eventually, as stated by [this comment](#432 (comment)). Fixes #1645. - removed `_hasLayout` variable - added repros https://github.com/software-mansion/react-native-screens/assets/91994767/226a32d7-728b-48dd-b21a-6a1e4195add2 https://github.com/software-mansion/react-native-screens/assets/91994767/32febcf1-d159-4a9d-ae3a-373042732a6d - added `Test1645.js` repro to test examples - added `Test432.tsx` repro to test examples - [x] Included code example that can be used to test this change - [x] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <[email protected]>
…-mansion#2188) ## Description This PR gets rid of undesired white flashes during `maybeAddToParentAndUpdateContainer`. The white flash was present on paper architecture when `unmountOnBlur` option was set to true on parent bottomStackNavigator (see repro). The affected logic was previously introduced or changed by following PRs: - software-mansion#600 - software-mansion#613 - software-mansion#643 The removed `_hasLayout` was initially added by software-mansion#600 in order to resolve an issue: software-mansion#432. However the logic was later changed by software-mansion#613 in order to fix another issue and the added `_hasLayout` may not fix anything eventually, as stated by [this comment](software-mansion#432 (comment)). Fixes software-mansion#1645. ## Changes - removed `_hasLayout` variable - added repros ## Screenshots / GIFs ### Before https://github.com/software-mansion/react-native-screens/assets/91994767/226a32d7-728b-48dd-b21a-6a1e4195add2 ### After https://github.com/software-mansion/react-native-screens/assets/91994767/32febcf1-d159-4a9d-ae3a-373042732a6d ## Test code and steps to reproduce - added `Test1645.js` repro to test examples - added `Test432.tsx` repro to test examples ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <[email protected]>
Description
When I'm using
@react-navigation/bottom-tabswith the native stack navigator, I see a white flash on tab transition in IOS.If I replace
@react-navigation/native-stackby@react-navigation/stack, white flash disappear.I think it can be related to #1276 but I'm not sure we talk about the same issue.
issue-native-stack.mp4
Steps to reproduce
Snack or a link to a repository
https://github.com/gkueny/native-stack-flash-issue-reproduction
Screens version
3.20.0 & 3.29.0
React Native version
0.69.7 & 0.73.6
Platforms
iOS
JavaScript runtime
No response
Workflow
React Native (without Expo)
Architecture
No response
Build type
Debug mode
Device
iOS simulator
Device model
No response
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: