Skip to content

Commit

Permalink
fix: Examples stopped to work after RN issue (#1632)
Browse files Browse the repository at this point in the history
## Description

See: facebook/react-native#35210 for
explanation why fixes are needed and why they look like it.



## Changes

Followed recommendations included in aforementioned issue.

* `FabricTestExample`: upgraded `React Native` to `0.70.5`
* `FabricExample`: upgraded `React Native` to `0.70.5`
* `Example`: upgraded `React Native` to `0.66.5`
* `TestsExample`: upgraded `React Native` to `0.70.5`

* `TVOSExample`: ??? Need to check whether it is affected


So `Test iOS build` CI fails due to [mismatched versions of
`hermes-engine` in `Podfile.lock` and version in
"snapshot"](https://github.com/software-mansion/react-native-screens/actions/runs/3435966238/jobs/5728946474).
Locally everything works fine, I updated pods, and have also run `pod
update hermes-engine --no-repo-update` and pushed all results -- it did
not help.

Since this is second time the problem occurs I decided to with similar
solution as earlier
[958b472](958b472)

I do not like this fix, but I do not find any other way to solve this.

## Test code and steps to reproduce

See that CI passes

## Checklist

- [x] Ensured that CI passes
  • Loading branch information
kkafar authored Nov 14, 2022
1 parent 02d7311 commit e770eed
Show file tree
Hide file tree
Showing 13 changed files with 2,343 additions and 2,487 deletions.
12 changes: 12 additions & 0 deletions .github/workflows/ios-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,18 @@ jobs:
working-directory: ${{ env.WORKING_DIRECTORY }}
run: yarn
- name: Install pods
id: install_pods
continue-on-error: true
working-directory: ${{ env.WORKING_DIRECTORY }}/ios
run: pod install
- if: steps.install_pods.outcome == 'failure'
id: remove_pods
name: Remove pods
working-directory: ${{ env.WORKING_DIRECTORY }}/ios
run: rm -fr build Pods Podfile.lock
- if: steps.remove_pods.outcome == 'success'
id: reinstall_pods
name: Reinstall pods
working-directory: ${{ env.WORKING_DIRECTORY }}/ios
run: pod install
- name: Build app
Expand Down
Loading

0 comments on commit e770eed

Please sign in to comment.