Skip to content

Commit

Permalink
chore: remove bridge reference & constructor
Browse files Browse the repository at this point in the history
suggested by @WoLewicki
  • Loading branch information
kkafar committed Apr 21, 2022
1 parent 2119955 commit c03b809
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
3 changes: 0 additions & 3 deletions ios/RNSScreenStackHeaderSubview.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ NS_ASSUME_NONNULL_BEGIN
#endif

@property (nonatomic) RNSScreenStackHeaderSubviewType type;
@property (nonatomic, weak) RCTBridge *bridge; // TODO: consider moving this to paper only section
- (instancetype)initWithBridge:(RCTBridge *)bridge; // TODO: consider moving this to paper only section
// right now it is possible to call this code in Fabric impl

#ifndef RN_FABRIC_ENABLED
@property (nonatomic, weak) UIView *reactSuperview;
Expand Down
10 changes: 1 addition & 9 deletions ios/RNSScreenStackHeaderSubview.mm
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,6 @@ @implementation RNSScreenStackHeaderSubview {

#pragma mark - Common

- (instancetype)initWithBridge:(RCTBridge *)bridge
{
if (self = [super init]) {
_bridge = bridge;
}
return self;
}

#ifdef RN_FABRIC_ENABLED

#pragma mark - Fabric specific
Expand Down Expand Up @@ -110,7 +102,7 @@ @implementation RNSScreenStackHeaderSubviewManager

- (UIView *)view
{
return [[RNSScreenStackHeaderSubview alloc] initWithBridge:self.bridge];
return [RNSScreenStackHeaderSubview new];
}

@end
Expand Down

0 comments on commit c03b809

Please sign in to comment.