Skip to content

Commit

Permalink
Remove legacy impl, use only the new
Browse files Browse the repository at this point in the history
  • Loading branch information
kkafar committed Dec 16, 2024
1 parent 93e1bef commit 6923769
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 450 deletions.
6 changes: 1 addition & 5 deletions ios/RNSScreenStack.mm
Original file line number Diff line number Diff line change
Expand Up @@ -750,11 +750,7 @@ - (void)dismissOnReload
// otherwise the screen will be just popped immediately due to no animation
((operation == UINavigationControllerOperationPop && shouldCancelDismiss) || _isFullWidthSwiping ||
[RNSScreenStackAnimator isCustomAnimation:screen.stackAnimation] || _customAnimation)) {
if (rns::kUsesNewAnimatorImpl) {
return [[RNSScreenStackAnimator alloc] initWithOperation:operation];
} else {
return [[RNSScreenStackAnimatorLegacy alloc] initWithOperation:operation];
}
return [[RNSScreenStackAnimator alloc] initWithOperation:operation];
}
return nil;
}
Expand Down
4 changes: 0 additions & 4 deletions ios/RNSScreenStackAnimator.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@

#import "RNSScreen.h"

namespace rns {
constexpr bool kUsesNewAnimatorImpl = false;
}

@interface RNSScreenStackAnimator : NSObject <UIViewControllerAnimatedTransitioning>

/// This property is filled whenever there is an ongoing animation and cleared on animation end.
Expand Down
Loading

0 comments on commit 6923769

Please sign in to comment.