-
-
Notifications
You must be signed in to change notification settings - Fork 516
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: iOS Fabric snapshotting mechanism (#1357)
This PR moves the snapshotting logic from Screen to ScreenStack. From now on a snapshot is made from only the top-most screen on the stack. Snapshots are used in order to have a transition animation during the go-back invoked from the JS side. Problems: - fix snapshots in nested stacks that break the flow - done - only make a snapshot of the top-most screen - done - swipe to go back gesture shouldn't be invoked on the first screen in a stack - done - layout shift on initial render - TBD - lack of animation in the nested stack on initial app load - done Co-authored-by: Wojciech Lewicki <[email protected]>
- Loading branch information
1 parent
a12e257
commit 0bfc63f
Showing
4 changed files
with
49 additions
and
65 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters