fix: brownfield integration #6774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
commented
Dec 3, 2024
packages/react-native-reanimated/apple/reanimated/apple/Fabric/REAInitializerRCTFabricSurface.h
Show resolved
Hide resolved
WoLewicki
commented
Dec 3, 2024
packages/react-native-reanimated/apple/reanimated/apple/REAModule.mm
Outdated
Show resolved
Hide resolved
piaskowyk
reviewed
Dec 4, 2024
packages/react-native-reanimated/apple/reanimated/apple/REAModule.mm
Outdated
Show resolved
Hide resolved
piaskowyk
approved these changes
Dec 4, 2024
tomekzaw
pushed a commit
that referenced
this pull request
Dec 9, 2024
## Summary In brownfield, ` // we need only one instance because SurfacePresenter is the same during the application lifetime` is false since you can destroy RN and create it again. ## Test plan Run Reanimated in brownfield and try to create and destroy the whole RN a couple of times.
Merged
tomekzaw
pushed a commit
that referenced
this pull request
Dec 9, 2024
## Summary In brownfield, ` // we need only one instance because SurfacePresenter is the same during the application lifetime` is false since you can destroy RN and create it again. ## Test plan Run Reanimated in brownfield and try to create and destroy the whole RN a couple of times.
tjzel
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Summary In brownfield, ` // we need only one instance because SurfacePresenter is the same during the application lifetime` is false since you can destroy RN and create it again. ## Test plan Run Reanimated in brownfield and try to create and destroy the whole RN a couple of times.
tjzel
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Summary In brownfield, ` // we need only one instance because SurfacePresenter is the same during the application lifetime` is false since you can destroy RN and create it again. ## Test plan Run Reanimated in brownfield and try to create and destroy the whole RN a couple of times.
tjzel
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Summary In brownfield, ` // we need only one instance because SurfacePresenter is the same during the application lifetime` is false since you can destroy RN and create it again. ## Test plan Run Reanimated in brownfield and try to create and destroy the whole RN a couple of times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In brownfield,
// we need only one instance because SurfacePresenter is the same during the application lifetimeis false since you can destroy RN and create it again.Test plan
Run Reanimated in brownfield and try to create and destroy the whole RN a couple of times.