feature: Detect edge-to-edge and set isStatusBarTranslucentAndroid / isNavigationBarTranslucentAndroid #6732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isNavigationBarTranslucentAndroid
|
Hi @zoontek, thanks for this PR. We briefly discussed this internally and @bartlomiejbloniarz will take a look on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to the PR I opened on the
react-native-screensrepository (I highly recommend to read the discussion there to understand the motivation behind this), this PR detects if the user enabled edge-to-edge and act accordingly:useAnimatedKeyboardare ignored, set totrueautomatically. If those are set, a warning is logged:It at some point this proposal lands in core,
react-native-is-edge-to-edgewill be updated to support both the library and the core edge-to-edge flag, making the transition seamless for the users.Test plan
isStatusBarTranslucentAndroid/isNavigationBarTranslucentAndroid, or set them to something else thantrue