Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable V8 nightly CI #6533

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Enable V8 nightly CI #6533

merged 3 commits into from
Sep 23, 2024

Conversation

piaskowyk
Copy link
Member

Summary

Now V8 supports react native 0.75 so we can turn on our CI 🎉

Test plan

Check CI ✅

tomekzaw
tomekzaw approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-enabling this! Can we also migrate npx react-native init to npx @react-native-community/cli init in all CI workflows in a separate PR?

@piaskowyk
Copy link
Member Author

Sure thing 🫡

@piaskowyk piaskowyk added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit c130153 Sep 23, 2024
8 checks passed
@piaskowyk piaskowyk deleted the @piaskowyk/enable-v8-CI branch September 23, 2024 08:32
@coado coado mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

@kmagiera kmagiera Awaiting requested review from kmagiera kmagiera is a code owner

@tjzel tjzel Awaiting requested review from tjzel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piaskowyk @tomekzaw