Fix colour comparison on Android #6383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
requested changes
Aug 12, 2024
...ges/react-native-reanimated/android/src/main/java/com/swmansion/reanimated/NodesManager.java
Outdated
Show resolved
Hide resolved
piaskowyk
approved these changes
Aug 12, 2024
tjzel
pushed a commit
that referenced
this pull request
Aug 17, 2024
Due to some recent changes some views are instances of CSSBackgroundDrawable instead of ReactViewBackgroundDrawable. I didn't track which PR introduced this change, since `ReactViewBackgroundDrawable` is marked as deprecated anyway. This PR contains changes to make snapshot colour comparison work again. <img width="635" alt="image" src="https://github.com/user-attachments/assets/6f6fbf7b-7bcc-4cc6-9a53-54d6861e6dcf">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to some recent changes some views are instances of CSSBackgroundDrawable instead of ReactViewBackgroundDrawable. I didn't track which PR introduced this change, since
ReactViewBackgroundDrawableis marked as deprecated anyway.This PR contains changes to make snapshot colour comparison work again.
Test plan