Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract AnimationUpdatesRecorder from TestRunner #6342

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Extract AnimationUpdatesRecorder from TestRunner #6342

merged 5 commits into from
Jul 31, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Jul 29, 2024 •
edited
Loading

Summary

Logic related with managing time when recording AnimationUpdates was moved to a separate file.
Also I delete the following functions:

  • public async setAnimationTimestamp
  • public async advanceAnimationByTime
  • public async advanceAnimationByFrames

Test plan

@Latropos Latropos marked this pull request as ready for review July 29, 2024 14:44
@Latropos Latropos requested a review from piaskowyk July 31, 2024 08:13
@Latropos Latropos added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 4c11d2e Jul 31, 2024
5 checks passed
@Latropos Latropos deleted the acynk/extract-animation-updates-recorder branch July 31, 2024 10:39
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 28, 2024
Closed
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@Bonnie-TJ Bonnie-TJ mentioned this pull request Sep 4, 2024
Merged
@tanyipeng834 tanyipeng834 mentioned this pull request Sep 4, 2024
Open
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Latropos @piaskowyk