Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move commonjs exports down for worklet files #6316

Merged
merged 4 commits into from
Jul 23, 2024
Merged

feat: Move commonjs exports down for worklet files #6316

merged 4 commits into from
Jul 23, 2024

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Jul 23, 2024 •
edited
Loading

Summary

Since Reanimated Babel Plugin breaks hoisting and newer Typescript hoists CommonJS exports by default we sometimes need to dehoist those exports.

Test plan

  • Add unit test suite.
  • Runtime tests pass.

@tjzel tjzel marked this pull request as ready for review July 23, 2024 09:56
@tjzel tjzel requested a review from tomekzaw July 23, 2024 09:56
tjzel
tjzel commented Jul 23, 2024
View reviewed changes
Copy link
Collaborator Author

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tjzel tjzel added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 818ed78 Jul 23, 2024
6 checks passed
@tjzel tjzel deleted the @tjzel/plugin/commonjs-exports-file-workletization branch July 23, 2024 11:30
@tjzel tjzel mentioned this pull request Jul 24, 2024
Merged
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@tanyipeng834 tanyipeng834 mentioned this pull request Sep 4, 2024
Open
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Open
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@yingbull yingbull mentioned this pull request Sep 28, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Oct 1, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 2, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@phucle1010 phucle1010 mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjzel @tomekzaw