Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web LA] Fix easing #6304

Merged
merged 5 commits into from
Jul 22, 2024
Merged

[Web LA] Fix easing #6304

merged 5 commits into from
Jul 22, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Jul 22, 2024

Summary

After #6163 was merged, each worklet function follows new naming convention. Since easings are worklets, their name property has also been changed. In web layout animations we were applying easing based on its name, therefore changing it resulted in only default linear easing being available on web.

This PR adds new Symbol into easing functions so that we can once again get their name and apply correct easing to animations.

Test plan

Tested on BasicLayoutAnimation example with Easing.exp

@m-bert m-bert requested review from tjzel and piaskowyk July 22, 2024 08:53
tjzel
tjzel approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern is still far from perfect but 🚀

@m-bert m-bert added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit a71d081 Jul 22, 2024
6 checks passed
@m-bert m-bert deleted the @mbert/fix-easing-on-web branch July 22, 2024 10:48
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@tanyipeng834 tanyipeng834 mentioned this pull request Sep 4, 2024
Open
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Open
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@yingbull yingbull mentioned this pull request Sep 28, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Oct 1, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 2, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@phucle1010 phucle1010 mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjzel tjzel tjzel approved these changes

@piaskowyk piaskowyk Awaiting requested review from piaskowyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-bert @tjzel