Fix Remove mutation parsing in Layout Animations
#6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Titozzz
approved these changes
Jul 17, 2024
piaskowyk
approved these changes
Jul 25, 2024
bartlomiejbloniarz
deleted the
@bartlomiejbloniarz/fix-fabric-la-remove-parsing
branch
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Sep 25, 2024
This was referenced Oct 1, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the way Remove mutations are parsed in
LayoutAnimationsProxy::pullTransaction. Before there was an assumption that parent removals will be later on the list than removals of their children. This is not accurate when a view is reparented. This assumption meant that we could recognize "root" nodes (basically entry point for exiting animations) while processing them. Now this part of logic has to be calculated after all Remove mutations are parsedfixes #6222
Test plan
Check
[LA]examples for regresions