Improve PerformanceMonitor's functionality
#6241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latekvo
changed the title
PerformanceMonitor's functionality
szydlovsky
approved these changes
Jul 10, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PerformanceMonitor unnecessarily used accumulator and time delta calculations.
I replaced those with time range measurement and added component props to modify smoothing amount.
Additionally smoothing is now modifiable via the
PerformanceMonitorProps,which are exported alongside
PerformanceMonitorTest plan
Not consistently reproducible.
Issue videos:
smoothing=5)Screen.Recording.2024-07-09.at.11.21.25.mov
Screen.Recording.2024-07-09.at.10.55.31.mov
Screen.Recording.2024-07-09.at.10.34.47.mov
New code video:
Screen.Recording.2024-07-09.at.12.18.00.mov
Related
This PR is a simpler successor to this PR.