Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate combineTransition #6161

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

piaskowyk
Copy link
Member

Summary

The combineTransition method doesn't seem to be necessary. It doesn't add any additional logic, duplicates the public API, and misleadingly suggests that combineTransition and EntryExitTransition are distinct entities. In fact, it has even been removed from the documentation page here.

Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right

@piaskowyk piaskowyk added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 1081ca1 Jul 15, 2024
7 checks passed
@piaskowyk piaskowyk deleted the @piaskowyk/deprecate-combineTransition branch July 15, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants