-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests of predefined exiting #6136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything fine, just a small nit
...mmon-app/src/examples/RuntimeTests/tests/layoutAnimations/exiting/predefinedExiting.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't find any issues 👍
...mmon-app/src/examples/RuntimeTests/tests/layoutAnimations/exiting/predefinedExiting.test.tsx
Outdated
Show resolved
Hide resolved
...mmon-app/src/examples/RuntimeTests/tests/layoutAnimations/exiting/predefinedExiting.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it comes to native snapshots, it requires some additional work, so let's leave it for now.
Summary
Add snapashot tests of predefined exiting
Test plan
Run tests