Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests of predefined exiting #6136

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Add tests of predefined exiting #6136

merged 5 commits into from
Jun 21, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Jun 19, 2024

Summary

Add snapashot tests of predefined exiting

Test plan

Run tests

@Latropos Latropos marked this pull request as ready for review June 19, 2024 11:28
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything fine, just a small nit

@piaskowyk piaskowyk self-requested a review June 19, 2024 15:42
Copy link
Contributor

@latekvo latekvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any issues 👍

Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it comes to native snapshots, it requires some additional work, so let's leave it for now.

@Latropos Latropos enabled auto-merge June 21, 2024 13:03
@Latropos Latropos added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit 85dee03 Jun 21, 2024
5 checks passed
@Latropos Latropos deleted the acynk/tests-exiting branch June 21, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants