Fix web-example
#6111
Merged
Fix web-example
#6111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following the transition to a monorepo structure, our web-example app stopped working due to an asset loading issue. Turns out that the
getAssetByIDfunction fromreact-native-webwas being called from the incorrect module. We believe this might have resulted in one module blocking an asset while another module was trying to load it, causing the application to crash.This PR modifies the
metro.config.jsinside theweb-examplefolder. It is now configured to ignore the@react-nativemodule from the root, which allows assets to load correctly.Test plan
Run
web-example.