Fix FlatList item generic types #5528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkadamczyk
force-pushed
the
@jkadamczyk/flatlist-generic-types
branch
from
8e2fc6d
to
698d127
Compare
tjzel
requested changes
Dec 27, 2023
There was a problem hiding this comment.
Thank you for finding that @jkadamczyk! I took the liberty and committed some minor changes directly into your PR. Everything looks well, apart from that one question that I asked. Once you assure me everything is fine I'm happy to merge it 😃
tjzel
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I think I ran into a typescript types regression, where the
Animated.FlatListtype was no longer generic. It always used the any type and I couldn't provide a custom item type myself anymore. I found it while upgrading from Reanimated v2 to v3. I think I managed to patch the generated .d.ts file properly locally and this is what did the trick for me.If this isn't matching your code style or requirements, I'm happy to work with you on making this work.
Test plan
Probably makes sense to see if it breaks anything in the example app but other than that 🤷