Remove deprecated ReanimatedJSIModulePackage
#3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
changed the title
ReanimatedJSIModulePackageReanimatedJSIModulePackage
tomekzaw
changed the title
ReanimatedJSIModulePackageReanimatedJSIModulePackage
piaskowyk
approved these changes
Aug 23, 2022
piaskowyk
deleted the
@tomekzaw/remove-deprecated-reanimatedjsimodulepackage
branch
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description This PR removes `ReanimatedJSIModulePackage` class which was used for initializing Reanimated 2.4.1 and below. Since 2.5.0, Reanimated automatically installs itself on Android. You can remove `getJSIModulePackage()` method in `MainApplication.java` of your app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
ReanimatedJSIModulePackageclass which was used for initializing Reanimated 2.4.1 and below.Since 2.5.0, Reanimated automatically installs itself on Android.
You can remove
getJSIModulePackage()method inMainApplication.javaof your app.Changes
ReanimatedJSIModulePackageTest code and steps to reproduce
Checklist