-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] Fix scale
#3031
Merged
Merged
[web] Fix scale
#3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
reviewed
Aug 6, 2024
latekvo
approved these changes
Aug 7, 2024
j-piasecki
approved these changes
Aug 7, 2024
Hey @m-bert ! We came across an uptick of this split crash on our side as well. Do you know if there is a release planned soon including this fix? Many thanks in advance and for this fix! |
Hi @EvertEt! Most likely this or the next week. |
Thank you! 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does 2 things:
style.scale
is defined in order to avoid crash when trying to callsplit
methodscaleY
if only one value was present instyle.scale
Note
While I'm not sure why
style.scale
wasundefined
when it should benone
, I suspect that this may be caused byNativeWind
Test plan
Using code below I've verified that scale is calculated correctly by manipulating
element.style
ininspector
.Test code