Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Add HoverGestureHandler #3027

Merged
merged 10 commits into from
Aug 6, 2024
Merged

[macOS] Add HoverGestureHandler #3027

merged 10 commits into from
Aug 6, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Aug 2, 2024 •
edited
Loading

Description

This PR adds HoverGestureHandler on macOS.

Limitations

It seems that Hover doesn't work when wrapped in ScrollView. I'm yet to find out what causes that.

Test plan

Tested on Hover example in example app.

@m-bert m-bert requested a review from j-piasecki August 2, 2024 15:24
@m-bert m-bert marked this pull request as ready for review August 2, 2024 15:24
j-piasecki
j-piasecki reviewed Aug 5, 2024
View reviewed changes
apple/Handlers/RNHoverHandler.m Show resolved Hide resolved
apple/Handlers/RNHoverHandler.m Show resolved Hide resolved
apple/Handlers/RNHoverHandler.m Outdated Show resolved Hide resolved
@m-bert m-bert requested a review from j-piasecki August 5, 2024 08:26
j-piasecki
j-piasecki approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look here: #3027 (comment)

Otherwise, looks good

@m-bert m-bert merged commit 1d7c4d1 into main Aug 6, 2024
3 checks passed
@m-bert m-bert deleted the @mbert/add-hover-macos branch August 6, 2024 10:39
@m-bert
Copy link
Contributor Author

m-bert commented Aug 6, 2024

There still might be some problems with blocking other handlers, but I think that they can be addressed in other PRs if necessary 😅

@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 23, 2024
Open
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@Adam-1052189 Adam-1052189 mentioned this pull request Sep 28, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@ColeCoffman ColeCoffman mentioned this pull request Oct 2, 2024
Open
@santiko santiko mentioned this pull request Oct 3, 2024
Open
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki j-piasecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-bert @j-piasecki