Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to auto-open last example in the example app #2918

Merged
merged 2 commits into from
May 22, 2024
Merged

Add option to auto-open last example in the example app #2918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ec975d
Add option to auto-open last example
j-piasecki May 17, 2024
ac1b5c6
Make switch clickable on web
j-piasecki May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 81 additions & 3 deletions example/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, { useEffect } from 'react';
import {
Text,
View,
Expand All @@ -10,13 +10,16 @@
} from 'react-native';
import {
createStackNavigator,
StackNavigationProp,
StackScreenProps,
} from '@react-navigation/stack';
import { NavigationContainer, ParamListBase } from '@react-navigation/native';
import {
GestureHandlerRootView,
RectButton,
Switch,
} from 'react-native-gesture-handler';
import AsyncStorage from '@react-native-async-storage/async-storage';
import OverflowParent from './src/release_tests/overflowParent';
import DoublePinchRotate from './src/release_tests/doubleScalePinchAndRotate';
import DoubleDraggable from './src/release_tests/doubleDraggable';
Expand Down Expand Up @@ -169,6 +172,9 @@
},
];

const OPEN_LAST_EXAMPLE_KEY = 'openLastExample';
const LAST_EXAMPLE_KEY = 'lastExample';

type RootStackParamList = {
Home: undefined;
TouchableExample: { item: string };
Expand Down Expand Up @@ -215,28 +221,84 @@
);
}

function navigate(
navigation: StackNavigationProp<ParamListBase>,
dest: string
) {
AsyncStorage.setItem(LAST_EXAMPLE_KEY, dest);
navigation.navigate(dest);
}

function MainScreen({ navigation }: StackScreenProps<ParamListBase>) {
useEffect(() => {
AsyncStorage.multiGet([OPEN_LAST_EXAMPLE_KEY, LAST_EXAMPLE_KEY]).then(
([openLastExample, lastExample]) => {
if (openLastExample[1] === 'true' && lastExample[1]) {
navigate(navigation, lastExample[1]);
}
}
);
// we only want to run this effect once
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

return (
<SafeAreaView style={styles.container}>
<ListWithHeader
style={styles.list}
sections={EXAMPLES}
keyExtractor={(example) => example.name}
ListHeaderComponent={OpenLastExampleSetting}
renderItem={({ item }) => (
<MainScreenItem
name={item.name}
onPressItem={(name) => navigation.navigate(name)}
onPressItem={(name) => navigate(navigation, name)}
/>
)}
renderSectionHeader={({ section: { sectionTitle } }) => (
<Text style={styles.sectionTitle}>{sectionTitle}</Text>
)}
ItemSeparatorComponent={() => <View style={styles.separator} />}

Check warning on line 261 in example/App.tsx

View workflow job for this annotation

GitHub Actions / check (example) 

Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “MainScreen” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true
/>
</SafeAreaView>
);
}

function OpenLastExampleSetting() {
const [openLastExample, setOpenLastExample] = React.useState(false);

useEffect(() => {
AsyncStorage.getItem(OPEN_LAST_EXAMPLE_KEY).then((value) => {
setOpenLastExample(value === 'true');
});
}, []);

function updateSetting(value: boolean) {
AsyncStorage.setItem(OPEN_LAST_EXAMPLE_KEY, value.toString());
setOpenLastExample(value);
}

return (
<RectButton
style={[styles.button, styles.autoOpenSetting]}
onPress={() => {
updateSetting(!openLastExample);
}}>
<View
style={styles.buttonContent}
pointerEvents={Platform.OS === 'web' ? 'box-only' : 'auto'}>
<Text>Open last example on launch</Text>
<Switch
value={openLastExample}
onValueChange={() => {
updateSetting(!openLastExample);
}}
/>
</View>
</RectButton>
);
}

interface MainScreenItemProps {
name: string;
onPressItem: (name: string) => void;
Expand Down Expand Up @@ -277,8 +339,24 @@
flex: 1,
height: 50,
padding: 10,
backgroundColor: '#fff',
},
buttonContent: {
flex: 1,
flexDirection: 'row',
alignItems: 'center',
backgroundColor: '#fff',
justifyContent: 'space-between',
},
autoOpenSetting: {
margin: 16,
borderRadius: 16,
backgroundColor: '#eef0ff',
paddingHorizontal: 16,
justifyContent: 'space-between',
elevation: 8,
shadowColor: '#000',
shadowOffset: { width: 0, height: 2 },
shadowOpacity: 0.25,
shadowRadius: 3.84,
},
});
1 change: 1 addition & 0 deletions example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"dependencies": {
"@expo/metro-config": "~0.18.1",
"@expo/metro-runtime": "^3.2.1",
"@react-native-async-storage/async-storage": "^1.23.1",
"@react-native-community/slider": "^4.5.2",
"@react-native-community/viewpager": "^5.0.11",
"@react-native-masked-view/masked-view": "^0.2.8",
Expand Down
19 changes: 19 additions & 0 deletions example/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,6 +1565,13 @@
mkdirp "^1.0.4"
rimraf "^3.0.2"

"@react-native-async-storage/async-storage@^1.23.1":
version "1.23.1"
resolved "https://registry.yarnpkg.com/@react-native-async-storage/async-storage/-/async-storage-1.23.1.tgz#cad3cd4fab7dacfe9838dce6ecb352f79150c883"
integrity sha512-Qd2kQ3yi6Y3+AcUlrHxSLlnBvpdCEMVGFlVBneVOjaFaPU61g1huc38g339ysXspwY1QZA2aNhrk/KlHGO+ewA==
dependencies:
merge-options "^3.0.4"

"@react-native-community/[email protected]":
version "13.6.6"
resolved "https://registry.yarnpkg.com/@react-native-community/cli-clean/-/cli-clean-13.6.6.tgz#87c7ad8746c38dab0fe7b3c6ff89d44351d5d943"
Expand Down Expand Up @@ -4971,6 +4978,11 @@ is-path-inside@^3.0.2:
resolved "https://registry.yarnpkg.com/is-path-inside/-/is-path-inside-3.0.3.tgz#d231362e53a07ff2b0e0ea7fed049161ffd16283"
integrity sha512-Fd4gABb+ycGAmKou8eMftCupSir5lRxqf4aD/vd0cD2qc4HL07OjCeuHMr8Ro4CoMaeCKDB0/ECBOVWjTwUvPQ==

is-plain-obj@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/is-plain-obj/-/is-plain-obj-2.1.0.tgz#45e42e37fccf1f40da8e5f76ee21515840c09287"
integrity sha512-YWnfyRwxL/+SsrWYfOpUtz5b3YD+nyfkHvjbcanzk8zgyO4ASD67uVMRt8k5bM4lLMDnXfriRhOpemw+NfT1eA==

is-plain-object@^2.0.4:
version "2.0.4"
resolved "https://registry.yarnpkg.com/is-plain-object/-/is-plain-object-2.0.4.tgz#2c163b3fafb1b606d9d17928f05c2a1c38e07677"
Expand Down Expand Up @@ -5951,6 +5963,13 @@ memory-cache@~0.2.0:
resolved "https://registry.yarnpkg.com/memory-cache/-/memory-cache-0.2.0.tgz#7890b01d52c00c8ebc9d533e1f8eb17e3034871a"
integrity sha512-OcjA+jzjOYzKmKS6IQVALHLVz+rNTMPoJvCztFaZxwG14wtAW7VRZjwTQu06vKCYOxh4jVnik7ya0SXTB0W+xA==

merge-options@^3.0.4:
version "3.0.4"
resolved "https://registry.yarnpkg.com/merge-options/-/merge-options-3.0.4.tgz#84709c2aa2a4b24c1981f66c179fe5565cc6dbb7"
integrity sha512-2Sug1+knBjkaMsMgf1ctR1Ujx+Ayku4EdJN4Z+C2+JzoeF7A3OZ9KM2GY0CpQS51NR61LTurMJrRKPhSs3ZRTQ==
dependencies:
is-plain-obj "^2.1.0"

merge-stream@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/merge-stream/-/merge-stream-2.0.0.tgz#52823629a14dd00c9770fb6ad47dc6310f2c1f60"
Expand Down
Loading