New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React Native 0.73 #2671

Merged

j-piasecki merged 20 commits into main from @jpiasecki/support-rn-73

Nov 23, 2023

Member

j-piasecki commented Nov 8, 2023 •

edited

Loading

Description

updates CMakeLists.txt so includes can be resolved
moves architecture-specific files out of src - at first, I thought that it would resolve the redefinition errors, but it seems like a clean build is required after changing the architecture. Anyway, since it's already there and unifies how source sets are handled I figured it may as well stay.

Updates root directory and FabricExample to RN 0.73. I've run into an issue with babel trying to upgrade the example app (some export were not transpiled to module.exports)

Test plan

Tested on FabricExample app (both architectures).

j-piasecki added 14 commits

November 8, 2023 13:09


          Update CMake to build with RN 0.73


          Move paper- and fabric-specific files out of src

7276ed2


          Update root dependencies

34cce33


          Update FabricExample

7d655cb


          Fix types

c7f88d3


          Update workflows

9540ae3


          Update workflows again

931eaba


          Fix types ...again

60eb235


          Eh...

2e3719c


          I don't like gh actions

6d093d0

):

fe93902


          Change jvm param

ff64969


          Bump to rc.5

6671e7c


          Init events lazily not eagerly

8e75977

jeroenvanhattem commented Nov 22, 2023

Could we get some eyes on this? I currently can't build Android because of the lack of support for RN0.73

j-piasecki linked an issue

that may be closed by this pull request

Not compatible with React Native 0.73 on Android #2681

Closed


          Format android

2f17864

j-piasecki marked this pull request as ready for review

November 23, 2023 11:31

j-piasecki added 5 commits

November 23, 2023 15:34


          Merge branch 'main' into @jpiasecki/support-rn-73

0c51df0


          Some fixes

d750c72


          Update files

46ed0e2


          Use cpp20 only when using RN 0.73 and higher

1ff3bbc


          Format

f81bb55

tomekzaw approved these changes

View reviewed changes

.github/workflows/ios-build.yml Show resolved Hide resolved

j-piasecki merged commit 24a7d1c into main

8 checks passed

j-piasecki deleted the @jpiasecki/support-rn-73 branch

November 23, 2023 16:22

renovate bot referenced this pull request in valora-inc/wallet


          fix(deps): update dependency react-native-gesture-handler to ^2.14.0 (#…

9cd7725

…4711)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-gesture-handler](https://togithub.com/software-mansion/react-native-gesture-handler)
| [`^2.13.4` ->
`^2.14.0`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.13.4/2.14.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-gesture-handler/2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-gesture-handler/2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-gesture-handler/2.13.4/2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-gesture-handler/2.13.4/2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-gesture-handler
(react-native-gesture-handler)</summary>

###
[`v2.14.0`](https://togithub.com/software-mansion/react-native-gesture-handler/releases/tag/2.14.0)

[Compare
Source](https://togithub.com/software-mansion/react-native-gesture-handler/compare/2.13.4...2.14.0)

#### ❗ Important changes

- Remove Gesture Handler limits on Android by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2672](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2672)
- Add a new gesture relation - `blocksHandlers` - working like `reversed
waitFor` by [@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2627](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2627)
- Support React Native 0.73 by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2671](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2671)

#### 🐛 Bug fixes

- Fix double `onPress` by [@&#8203;m-bert](https://togithub.com/m-bert)
in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2657](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2657)
- Fix tvOS build by [@&#8203;m-bert](https://togithub.com/m-bert) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2654](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2654)
- Add a non-null assertion for
`reactApplicationContext.javaScriptContextHolder` by
[@&#8203;UNIDY2002](https://togithub.com/UNIDY2002) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2662](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2662)
- Move REACT_NATIVE_VERSION to native-only code by
[@&#8203;chriscoomber](https://togithub.com/chriscoomber) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2666](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2666)
- Fix selection when TalkBack is enabled by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2669](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2669)
- Fix inputs focus on safari by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2675](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2675)

#### 🔢 Miscellaneous

- Bump browserify-sign from 4.2.1 to 4.2.2 in /example by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2661](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2661)
- Change Alert to console.log in new docs by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2670](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2670)
- Remove `handlersToCancel` on web. by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2679](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2679)

#### New Contributors

- [@&#8203;chriscoomber](https://togithub.com/chriscoomber) made their
first contribution in
[https://github.com/software-mansion/react-native-gesture-handler/pull/2666](https://togithub.com/software-mansion/react-native-gesture-handler/pull/2666)

**Full Changelog**:
software-mansion/react-native-gesture-handler@2.13.4...2.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet