Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LongPressGestureHandler web discrepancy on move events #1098

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

connectdotz
Copy link
Contributor

This PR fixes the following issues for the web implementation

  1. The LongPressGuestureHandler on mobile (ios/android) emits move events after being activated but the web implementation does not. Modified the PressGestureHandler.onRawEvent to pass along the move event.
  2. in createHander static class proprType is not supported in react-native-web, fixed in createHander

fix #1097

@jakub-gonet jakub-gonet requested a review from EvanBacon August 11, 2020 14:23
@noldidrita
Copy link

I can confirm this works.

Copy link
Collaborator

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@EvanBacon EvanBacon merged commit 7edb337 into software-mansion:master Sep 22, 2020
braincore pushed a commit to braincore/react-native-gesture-handler that referenced this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LongPressGestureHandler discrepancy between web and mobile implementations
3 participants