Deploy panic_data handling
#2157
Conversation
Arcticae
force-pushed
the
2024-panicdata-handling
branch
from
97f2edd
to
4da575a
Compare
Arcticae
force-pushed
the
2024-panicdata-handling
branch
from
4da575a
to
adbe3f1
Compare
Arcticae
requested review from
MaksymilianDemitraszek,
karol-bisztyga and
cptartur
and removed request for
a team and
karol-bisztyga
| fn felt_from_short_string(short_str: &str) -> Felt252 { | ||
| return Felt252::from_bytes_be(short_str.as_bytes()); | ||
| } |
There was a problem hiding this comment.
I'd add some simple unit test for that
| fn try_extract_panic_data(err: &str) -> Option<Vec<Felt252>> { | ||
| let re = Regex::new(r#"(?m)^Got an exception while executing a hint: Custom Hint Error: Execution failed. Failure reason: "(.*)"\.$"#) | ||
| .expect("Could not create panic_data matching regex"); | ||
|
|
||
| if let Some(captures) = re.captures(err) { | ||
| if let Some(panic_data_match) = captures.get(1) { | ||
| let panic_data_felts: Vec<Felt252> = panic_data_match | ||
| .as_str() | ||
| .split(", ") | ||
| .map(felt_from_short_string) | ||
| .collect(); | ||
|
|
||
| return Some(panic_data_felts); | ||
| } | ||
| } | ||
| None | ||
| } |
| insert_value_to_cellref!(vm, deployed_contract_address, contract_address)?; | ||
| insert_value_to_cellref!(vm, panic_data_end, ptr)?; |
There was a problem hiding this comment.
Why are we inserting an address and panic data end here? Shouldn't it be panic data start end and?
There was a problem hiding this comment.
Keep in mind this will change anyways after merging #2163 - we will just return plain Span<felt252> every time and extract panic_data in cairo code.
You can look at the draft for handling errors in deploy cheatcode, but feel free to do it however you feel like is the best.
I think we should try to not change the user interface too much while reimplementing it using general cheatcode.
| panic_data.append('PANIK'); | ||
| panic_data.append('DEJTA'); |
|
Please can we wait with merging for general cheatcode impl? 🥺 |
|
Make sure to remove the TODO after implementing it |
Checklist