Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle panic_data in Deploy #2024

Open
karol-bisztyga opened this issue May 30, 2023 · 0 comments
Open

Handle panic_data in Deploy #2024

karol-bisztyga opened this issue May 30, 2023 · 0 comments
Assignees
@Arcticae
Milestone
Rust test runner

Comments

@karol-bisztyga
Copy link
Contributor

karol-bisztyga commented May 30, 2023 •
edited by Arcticae
Loading

Source:

protostar/protostar-rust/src/cheatcodes_hint_processor.rs

Line 156 in 0a0748e

// TODO https://github.com/software-mansion/protostar/issues/2024

Edit:
Most of the errors should not be recoverable, excluding those with txn execution (which is handled by panic_data).

Separately, we should consider avoiding having error_code in cases which we always return 0

Edit2:
Delegated Invokes and Calls error handling to #2156
@karol-bisztyga karol-bisztyga added this to the Rust test runner milestone May 30, 2023
@karol-bisztyga karol-bisztyga mentioned this issue May 30, 2023
Closed
@Arcticae Arcticae self-assigned this Jun 27, 2023
@Arcticae Arcticae changed the title Instead of panicking, handle errors and return error code in rust cheat codes Handle panic_data in Declare (and Invoke) Jun 28, 2023
@Arcticae Arcticae linked a pull request Jun 30, 2023 that will close this issue
Deploy panic_data handling #2157
Closed
3 tasks
@Arcticae Arcticae changed the title Handle panic_data in Declare (and Invoke) Handle panic_data in Declare Jun 30, 2023
@Arcticae Arcticae changed the title Handle panic_data in Declare Handle panic_data in Deploy Jul 4, 2023
@cptartur cptartur mentioned this issue Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arcticae Arcticae

Labels
None yet
Projects
None yet
Milestone
Rust test runner
Development

Successfully merging a pull request may close this issue.

Deploy panic_data handling software-mansion/protostar
2 participants
@Arcticae @karol-bisztyga