Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore inconsistent runs that have a status set to 'in_progress' but conclusion is 'success' #50

Closed
wants to merge 3 commits into from

Conversation

gustaff-weldon
Copy link
Contributor

We have encountered infinite wait issues with this plugin when for some reason some runs were marked as in_progress but also successful:

{
  "id": 4743138635,
  "name": "ci",
  "head_branch": "main",
  "head_sha": "094866bfa4cece7810af835a51f6aacbe6051654",
  "path": ".github/workflows/ci.yml",
  "run_number": 54898,
  "event": "push",
  "status": "in_progress",
  "conclusion": "success",
  "workflow_id": 3110243,
  "check_suite_id": 12339949756,
  "check_suite_node_id": "CS_kwDOBPfPnM8AAAAC34SwvA",
  "created_at": "2023-04-19T12:13:16Z",
  "updated_at": "2023-04-19T12:27:06Z",

For such weird runs, turnstyle keeps waiting forever.

This PR filters out all such cases, to prevent action from waiting for these.

@chenrui333 chenrui333 changed the title Ignore inconsistent runs that have a status set to 'in_progress' but conclusion is 'success' fix: ignore inconsistent runs that have a status set to 'in_progress' but conclusion is 'success' Jun 19, 2024
@chenrui333 chenrui333 added the bug Something isn't working label Jun 19, 2024
Copy link
Collaborator

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add some tests and fix the merge conflict, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants