Add 'publish' method to expose a port #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…linking it to the host
Miaxos
commented
Oct 13, 2019
| @@ -1721,7 +1775,9 @@ mod tests { | |||
| .server_address("https://example.org") | |||
| .build(); | |||
| assert_eq!( | |||
| base64::encode(r#"{"username":"user_abc","password":"password_abc","email":"email_abc","serveraddress":"https://example.org"}"#), | |||
| base64::encode( | |||
Miaxos
commented
Oct 13, 2019
| @@ -1676,7 +1730,7 @@ mod tests { | |||
| assert_eq!( | |||
| r#"{"HostConfig":{"RestartPolicy":{"MaximumRetryCount":10,"Name":"on-failure"}},"Image":"test_image"}"#, | |||
| options.serialize().unwrap() | |||
| ); | |||
| ); | |||
Miaxos
changed the title
|
I'll write the issue, then add the PR Edit: Issue #199 |
|
thanks @Miaxos . looks great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
I added the publish function to only expose port on the container instead of mapping ports.
Context:
I got an automated nginx_proxy (https://github.com/jwilder/nginx-proxy) that'll detect automatically if a container is added to his network and for that, you only need to expose ports of the container with a
docker run --expose 5000 somethingand if multiples, specify it with env variablesBut with shiplift, I couldn't only expose a port, I had to do the mapping.
How did you verify your change:
By testing and with units tests.
What (if anything) would need to be called out in the CHANGELOG for the next release:
publish method added to publish container's ports.