Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version to node20 #406

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

timheuer
Copy link
Contributor

Fixes #404 updating the action to use node20

Update to node20
@s1204IT
Copy link

s1204IT commented Jan 30, 2024

@softprops
Now that the node16 warning has started appearing, this should be addressed as soon as possible.

@peabee
Copy link

peabee commented Feb 2, 2024

@softprops - would be great if this update could be actioned - thanks.

@jamesbuddrige
Copy link

+1 For upgrading this

@lxiaya
Copy link

lxiaya commented Feb 4, 2024

update - thanks.

@steven-pribilinskiy
Copy link

@softprops merge it please

@softprops softprops merged commit 4634c16 into softprops:master Feb 5, 2024
@peabee
Copy link

peabee commented Feb 6, 2024

Now all we have to do is retagging the v1 tag!

Needs to be a new release...............??

@timheuer
Copy link
Contributor Author

timheuer commented Feb 6, 2024

@softprops I'd recommend tagging as v2 (or major version bump). As an action owner myself, I updated other tags and had some consumers complain (rightfully) as because there are breaking changes between node16->node20 and thus having this in the flow caused other parts of their node scripts to fail, etc. So I re-released mine with major version bump for this reason. Just a thought ;-)

@ivanlemeshev
Copy link

Please create a new release. We need this action to work.

@timheuer
Copy link
Contributor Author

timheuer commented Feb 8, 2024

As an alternate everyone you can modify your action to use a commit hash.

So you can use
softprops/action-gh-release@ 4634c16e79c963813287e889244c50009e7f0981

this will use the merged node20 commit.

xprateek referenced this pull request in xprateek/aosp_kernel_gki_builder Feb 9, 2024
Files/Folders List (+/-) :
.github/workflows/prebuilt-android11-5.4-lts.yml
.github/workflows/prebuilt-android11-5.4.yml
.github/workflows/prebuilt-android12-5.10-lts.yml
.github/workflows/prebuilt-android12-5.10.yml
.github/workflows/prebuilt-android12-5.4-lts.yml
.github/workflows/prebuilt-android12-5.4.yml
.github/workflows/prebuilt-android13-5.10-lts.yml
.github/workflows/prebuilt-android13-5.10.yml
.github/workflows/prebuilt-android13-5.15-lts.yml
.github/workflows/prebuilt-android13-5.15.yml
.github/workflows/prebuilt-android14-5.15-lts.yml
.github/workflows/prebuilt-android14-5.15.yml
.github/workflows/prebuilt-android14-6.1-lts.yml
.github/workflows/prebuilt-android14-6.1.yml
.github/workflows/prebuilt-android15-6.1.yml
.github/workflows/prebuilt-android15-6.6.yml

Signed-off-by       : Prateek Maru <[email protected]>
Signed-off-date     : 10-Feb-2024 00:45:11 IST
Previous Change-ID  : f338d3f
@akinomyoga akinomyoga mentioned this pull request Feb 13, 2024
@akinomyoga
Copy link

akinomyoga commented Feb 13, 2024

@softprops Is there a plan to tag a new release? I'm wondering when I should update the GitHub actions in my projects. If the new tag will be released soon, I'd like to wait for it to avoid cluttering the history with a temporary change. If the new tag will not appear, I probably need to use the (temporary) solution suggested in #406 (comment).

@barunprasad
Copy link

We're currently awaiting compatibility of the latest tag with Node.js version 20. From my perspective, it would be advisable to consider a major version increment in light of this.

@trackleft
Copy link

@softprops hasn't done anything in github for a couple of weeks, hope he's OK
image

jshiell added a commit to jshiell/checkstyle-idea that referenced this pull request Feb 18, 2024
@softprops
Copy link
Owner

Sorry folks hope to get to this soon. I'm through a layoff event in my life and trying to prioritize getting certain things in order.

@akinomyoga
Copy link

Oh, I'm sorry to hear that. I can wait, so please take your time for your life. Needless to say, that's more important than GitHub Action. Don't worry, there are currently just warnings, and nothing is broken.

@mikeage
Copy link

mikeage commented Feb 24, 2024

I admit, I chuckled at the fact that of all the repos to be missing a release, it was this one ;-)

But seriously, I hope everything is ok and you're doing well. Work stress is never fun.

@tychobrailleur
Copy link

Sorry folks hope to get to this soon. I'm through a layoff event in my life and trying to prioritize getting certain things in order.

Virtual hug 🫂 Take care of yourself.

@dirkhh
Copy link

dirkhh commented Feb 25, 2024

layoffs suck. life comes first.
all the best

@baruchiro
Copy link

Hi man, working on an Open Source project for free is sometimes not rewarding. I can't promise we will find you a new job, but we are a small community here, if you need something from us, such as maintaining your OpenSource, sharing your LinkedIn post, connections, and so on, don't hesitate to ask 😍

TeamworkGIF

@softprops
Copy link
Owner

thanks for the support folks

sorry for the huge delay. This should now be fixed.

You should now use softprops/action-gh-release@v2.

I've validated this in a test run repo here

PS. THANK YOU everyone for your emotional support. I really need(ed) it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Node.js 16 with Node.js 20