-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node version to node20 #406
Conversation
Update to node20
@softprops |
@softprops - would be great if this update could be actioned - thanks. |
+1 For upgrading this |
update - thanks. |
@softprops merge it please |
Needs to be a new release...............?? |
@softprops I'd recommend tagging as v2 (or major version bump). As an action owner myself, I updated other tags and had some consumers complain (rightfully) as because there are breaking changes between node16->node20 and thus having this in the flow caused other parts of their node scripts to fail, etc. So I re-released mine with major version bump for this reason. Just a thought ;-) |
Please create a new release. We need this action to work. |
As an alternate everyone you can modify your action to use a commit hash. So you can use this will use the merged node20 commit. |
Files/Folders List (+/-) : .github/workflows/prebuilt-android11-5.4-lts.yml .github/workflows/prebuilt-android11-5.4.yml .github/workflows/prebuilt-android12-5.10-lts.yml .github/workflows/prebuilt-android12-5.10.yml .github/workflows/prebuilt-android12-5.4-lts.yml .github/workflows/prebuilt-android12-5.4.yml .github/workflows/prebuilt-android13-5.10-lts.yml .github/workflows/prebuilt-android13-5.10.yml .github/workflows/prebuilt-android13-5.15-lts.yml .github/workflows/prebuilt-android13-5.15.yml .github/workflows/prebuilt-android14-5.15-lts.yml .github/workflows/prebuilt-android14-5.15.yml .github/workflows/prebuilt-android14-6.1-lts.yml .github/workflows/prebuilt-android14-6.1.yml .github/workflows/prebuilt-android15-6.1.yml .github/workflows/prebuilt-android15-6.6.yml Signed-off-by : Prateek Maru <[email protected]> Signed-off-date : 10-Feb-2024 00:45:11 IST Previous Change-ID : f338d3f
@softprops Is there a plan to tag a new release? I'm wondering when I should update the GitHub actions in my projects. If the new tag will be released soon, I'd like to wait for it to avoid cluttering the history with a temporary change. If the new tag will not appear, I probably need to use the (temporary) solution suggested in #406 (comment). |
We're currently awaiting compatibility of the latest tag with Node.js version 20. From my perspective, it would be advisable to consider a major version increment in light of this. |
@softprops hasn't done anything in github for a couple of weeks, hope he's OK |
Sorry folks hope to get to this soon. I'm through a layoff event in my life and trying to prioritize getting certain things in order. |
Oh, I'm sorry to hear that. I can wait, so please take your time for your life. Needless to say, that's more important than GitHub Action. Don't worry, there are currently just warnings, and nothing is broken. |
I admit, I chuckled at the fact that of all the repos to be missing a release, it was this one ;-) But seriously, I hope everything is ok and you're doing well. Work stress is never fun. |
Virtual hug 🫂 Take care of yourself. |
layoffs suck. life comes first. |
Hi man, working on an Open Source project for free is sometimes not rewarding. I can't promise we will find you a new job, but we are a small community here, if you need something from us, such as maintaining your OpenSource, sharing your LinkedIn post, connections, and so on, don't hesitate to ask 😍 |
thanks for the support folks sorry for the huge delay. This should now be fixed. You should now use I've validated this in a test run repo here PS. THANK YOU everyone for your emotional support. I really need(ed) it. |
Fixes #404 updating the action to use
node20