-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The runner has received a shutdown signal #353
Comments
@softprops is there anything else we can provide to help debugging the issue? |
like this ,workflow:
return
|
Is there anyone who can help fix this issue? It bothers me so much |
@softprops is it possible to limit the number of files uploaded? If we send them one by one it might work properly. |
@grische |
I encountered the same issue a few hours ago, while trying to release a few large files via this GitHub Action. |
I ran into the same issue. I believe it is because the runner ran out of memory because this tool loads all the files into memory before uploading them: action-gh-release/src/github.ts Line 131 in c9b46fe
Well in my case it was 4 files, each around 1.5 GB so 6 GB total so no wonder it was too much. It is of course a big mistake that this is happening. Upload (especially upload with potentially large files) should always be written in a way that doesn't load them into memory all at once but just one chunk at a time. |
Did someone find an alternative tool that doesn't have this issue? There is a ton on GitHub Actions Marketplace but so far I couldn't find one that would be similarly feature complete and not have this bug. |
@softprops It shouldn't be too difficult to fix this bug. Most likely you just need to use this: https://www.geeksforgeeks.org/node-js-fs-createreadstream-method/ |
…n dispatch (#173) The release action [failed](https://github.com/flashinfer-ai/flashinfer/actions/runs/8227731974/job/22501369048) because [action-gh-release](https://github.com/softprops/action-gh-release) action do not support uploading multiple large files at a time: softprops/action-gh-release#353 This PR changes the behavior of release job to upload artifacts in multiple batches. Also, #172 removes the instantiation of page prefill kernels for `page_size=8`, this PR fixes the behavior of `DISPATCH_PAGE_SIZE` by removing corresponding branches.
Previously all assets were being read synchronously into memory, making the action unsuitable for releasing very large assets. Because the client library allows stream body inputs (it just forwards it to the underlying `fetch` implementation), just do it. Fixes: softprops#353 Signed-off-by: WANG Xuerui <[email protected]>
Previously all assets were being read synchronously into memory, making the action unsuitable for releasing very large assets. Because the client library allows stream body inputs (it just forwards it to the underlying `fetch` implementation), just do it. The idea is also suggested by @enumag in softprops#353 (comment). Fixes: softprops#353 Signed-off-by: WANG Xuerui <[email protected]>
While running the action-gh-release action, we regularly encounter issues that the operation has been cancelled.
It failed after 17 minutes, so I assume it is not a timeout.
It seems to be happening after the last uploaded concluded.
Here is an example running with Debug enabled: https://github.com/freifunkMUC/site-ffm/actions/runs/4940203059/jobs/8842882643
Here are the last lines before it failed:
Other (non-expired) examples are:
The text was updated successfully, but these errors were encountered: