Replace PKCS11 headers with a version from p11-kit #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me overall, though I haven't been able to isolate which parts were new. I could review that part when sent to p11-kit. |
|
@nmav I submitted p11-glue/p11-kit#181 to have headers updated. |
|
Thank you for this pull request with the PKCS#11 header file from p11-kit. It is looking good. Just waiting for the discussion on p11-glue/p11-kit#181. |
|
Patch updated according to the discussion. |
Since headers provided by OASIS PKCS11 TC have not-exactly free license (they do not allow modification), use an alternative header from p11-kit which is licensed under a more liberal license. Vendor-specific constants were also updated to PKCS11 standard v3.0 where possible.
|
@bellgrim this is the final version, merged to p11-kit already. |
|
Thanks! |
graebm
added a commit
to awslabs/aws-c-io
that referenced
this pull request
Feb 14, 2024
**Issue #:** #621 The OASIS IPR license is not on Fedora's approved license list. This license is at the top of the PKCS#11 headers released by the OASIS technical committee that standardizes PKCS#11. So it's a good idea to use the official headers, right? No, wrong, apparently. [Here](latchset/pkcs11-provider#76) [are](tpm2-software/tpm2-pkcs11#338) [many](softhsm/SoftHSMv2#412) [other](https://gitlab.isc.org/isc-projects/bind9/-/issues/414) [open](containers/podman#13906) [source](https://mail.openjdk.org/pipermail/jdk-dev/2021-May/005526.html) [projects](https://lists.fedoraproject.org/archives/list/[email protected]/thread/2QXHMTZ47DMMARJVI6PUMSYUPVFAGLCV/) being confused by the license, and replacing the headers that container it. **Description of changes:** Replace OASIS headers with public domain headers, sourced from https://github.com/latchset/pkcs11-headers
alfred2g
pushed a commit
to awslabs/aws-c-io
that referenced
this pull request
May 21, 2024
**Issue #:** #621 The OASIS IPR license is not on Fedora's approved license list. This license is at the top of the PKCS#11 headers released by the OASIS technical committee that standardizes PKCS#11. So it's a good idea to use the official headers, right? No, wrong, apparently. [Here](latchset/pkcs11-provider#76) [are](tpm2-software/tpm2-pkcs11#338) [many](softhsm/SoftHSMv2#412) [other](https://gitlab.isc.org/isc-projects/bind9/-/issues/414) [open](containers/podman#13906) [source](https://mail.openjdk.org/pipermail/jdk-dev/2021-May/005526.html) [projects](https://lists.fedoraproject.org/archives/list/[email protected]/thread/2QXHMTZ47DMMARJVI6PUMSYUPVFAGLCV/) being confused by the license, and replacing the headers that container it. **Description of changes:** Replace OASIS headers with public domain headers, sourced from https://github.com/latchset/pkcs11-headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since headers provided by OASIS PKCS11 TC have not-exactly free license (they do not allow modification), use an alternative header from p11-kit which is licensed under a more liberal license.
For the context, please look at the discussion on the Fedora Project's legal mailing list: https://lists.fedoraproject.org/archives/list/[email protected]/message/ODP2HLWAZETWVMSAOWMUBGZZXSKLLZ74/
I've asked OASIS PKCS11 TC chair to help with updating licensing terms for the PKCS11 headers they produce but was advised to follow this way as it will take a lot of time to sort things out in the technical committee.
@nmav, I had to expand a bit pkcs11.h from p11-kit to include newer ciphers supported by SoftHSM. I'll submit pkcs11.h back to p11-kit with these updates soon but I'd appreciate if you'd review these changes too.