Feature/remove sheriff.config from lint programatically #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
With hindsight, if you like this PR, I'd be happy to write more unit tests to cover all possible include/exclude configurations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per your comment, 2nd bullet point: #161 (comment)
This PR adds the ability for rules to have a filename inclusions or exclusions list set inside the
createRulefactory and filters the 'sheriff.config.ts' file from all the existing rules. This allows a future set of rules that can be filename/type-specific.Of my two PRs this is the most testable, but both are written with consideration to solving #165.