Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint): support re-exports in eslint #138

Conversation

rainerhahnekamp
Copy link
Collaborator

Closes: #137

@rainerhahnekamp rainerhahnekamp marked this pull request as draft September 30, 2024 12:08
@rainerhahnekamp rainerhahnekamp force-pushed the feat/export-as-implicit-import branch from 13f2d24 to c6266c1 Compare October 2, 2024 20:00
@rainerhahnekamp rainerhahnekamp self-assigned this Oct 2, 2024
@rainerhahnekamp rainerhahnekamp marked this pull request as ready for review October 2, 2024 20:01
@rainerhahnekamp rainerhahnekamp force-pushed the feat/export-as-implicit-import branch from c6266c1 to 447b94b Compare October 2, 2024 20:12
@rainerhahnekamp rainerhahnekamp changed the title feat: support implicit imports feat(eslint): support re-exports in eslint Oct 2, 2024
Dependencies can be accessed directly via exports, and these cases need to
be checked against existing rules. The CLI was already detecting such
violations, but ESLint missed them. This commit ensures that exports are
now properly checked as well.
@rainerhahnekamp rainerhahnekamp force-pushed the feat/export-as-implicit-import branch from 3ed4b99 to ff49446 Compare October 5, 2024 18:42
Copy link

sonarqubecloud bot commented Oct 5, 2024

@rainerhahnekamp rainerhahnekamp merged commit 883a472 into softarc-consulting:main Oct 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sheriff does not report violations when a barrel file (index.ts) wrongly export modules from other places
1 participant