fix(core): fix bug in dependency rules #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerhahnekamp
force-pushed
the
fix/dependency-rules
branch
from
6b019bc to
8683786
Compare
Each from tag must match one of the to tags of its dependency.
The old implementation did it the opposite.
It iterated over all to tags and at least one from tag had to
match.
That meant, that from tags could end up having no match at all.
Example:
Module customer-feature: ['domain:holidays', 'type:feature']
Module shared-ui: ['shared']
Dependency Rules:
{
'domain:*': sameTag,
'type:feature': ['shared']
}
Since shared-ui had only one tag and type:feature had clearance, the dependency worked.
Not it would fail because 'domain:holidays' would also have to have access 'shared'.
rainerhahnekamp
force-pushed
the
fix/dependency-rules
branch
from
8683786 to
f9399ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each from tag must match one of the to tags of its dependency.
The old implementation forsaw that per to tag, at least one from
has to match.
That meant, that from tags could end up having no match at all.
Example:
Module customer-feature: ['domain:holidays', 'type:feature']
Module shared-ui: ['shared']
Dependency Rules:
{
'domain:*': sameTag,
'type:feature': ['shared']
}
Since shared-ui had only one tag and type:feature had clearance, the dependency worked.
Not it would fail because 'domain:holidays' would also have to have access 'shared'.
TODOs: