refactor: no need to process executeRuleWithContext when excluded

softarc-consulting · Dec 8, 2024 · 16e5ec1 · 16e5ec1
1 parent 754d50c
commit 16e5ec1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/eslint-plugin/src/lib/rules/create-rule.ts b/packages/eslint-plugin/src/lib/rules/create-rule.ts
@@ -21,17 +21,17 @@ export const createRule: (
   executor: Executor,
 ) => Rule.RuleModule = (ruleName, fileFilter, executor) => ({
   create: (context) => {
+    const filename = context.filename ?? context.getFilename();
+    if (isExcluded(fileFilter, filename)) {
+      return {};
+    }
+
     let isFirstRun = true;
     let hasInternalError = false;
     const executeRuleWithContext = (node: ExecutorNode) => {
-      const filename = context.filename ?? context.getFilename();
       const sourceCode =
         context.sourceCode?.text ?? context.getSourceCode().text;
 
-      if (isExcluded(fileFilter, filename)) {
-        return;
-      }
-
       if (!hasInternalError) {
         try {
           // don't process special export `export const value = {n: 1};`

diff --git a/packages/eslint-plugin/src/lib/rules/tests/create-rule.spec.ts b/packages/eslint-plugin/src/lib/rules/tests/create-rule.spec.ts
@@ -35,7 +35,7 @@ describe('create rule', () => {
     expect(spy).toHaveBeenCalledTimes(2);
   });
 
-  it.only('should NOT call the rule executor for any import or export types when filename is "sheriff.config.ts"', () => {
+  it('should NOT call the rule executor for any import or export types when filename is "sheriff.config.ts"', () => {
     tester.run('test-rule', testRule, {
       valid: [
         {