Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default proxy to javassist. #79

Merged
merged 1 commit into from
May 3, 2018

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented May 3, 2018

  1. Remove method cache of ReflectUtils.
  2. Split ClassUtils#getDefaultArg to getDefaultPrimitiveValue and getDefaultWrapperValue.
  3. Set method to SofaRequest when user JavassistProxy.

1. Remove method cache of ReflectUtils.
2. Split ClassUtils#getDefaultArg to  getDefaultPrimitiveValue and getDefaultWrapperValue.
3. Set method to SofaRequest when user JavassistProxy.
@ujjboy ujjboy added the enhancement New feature or request label May 3, 2018
@ujjboy ujjboy added this to the 5.4.0 milestone May 3, 2018
@ujjboy ujjboy self-assigned this May 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #79 into master will increase coverage by 0.39%.
The diff coverage is 94.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
+ Coverage     63.49%   63.88%   +0.39%     
- Complexity      592      596       +4     
============================================
  Files           263      263              
  Lines         11294    11303       +9     
  Branches       1887     1892       +5     
============================================
+ Hits           7171     7221      +50     
+ Misses         3150     3111      -39     
+ Partials        973      971       -2
Impacted Files Coverage Δ Complexity Δ
...va/com/alipay/sofa/rpc/message/MessageBuilder.java 88.23% <ø> (ø) 0 <0> (ø) ⬇️
...om/alipay/sofa/rpc/common/json/BeanSerializer.java 66.27% <ø> (ø) 0 <0> (ø) ⬇️
...y/sofa/rpc/bootstrap/DefaultProviderBootstrap.java 60.1% <ø> (-0.21%) 0 <0> (ø)
...com/alipay/sofa/rpc/common/utils/ReflectUtils.java 81.81% <100%> (+20.19%) 0 <0> (ø) ⬇️
...a/com/alipay/sofa/rpc/common/utils/ClassUtils.java 80.27% <100%> (+0.83%) 0 <0> (ø) ⬇️
...lipay/sofa/rpc/proxy/jdk/JDKInvocationHandler.java 73.07% <100%> (-6.09%) 0 <0> (ø)
...lipay/sofa/rpc/proxy/javassist/JavassistProxy.java 79.45% <86.2%> (+4.25%) 0 <0> (ø) ⬇️
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 64.68% <87.5%> (+0.25%) 0 <0> (ø) ⬇️
.../com/alipay/sofa/rpc/log/MiddlewareLoggerImpl.java 76.81% <0%> (-5.8%) 0% <0%> (ø)
...lipay/sofa/rpc/codec/antpb/ProtobufSerializer.java 53.84% <0%> (-2.2%) 17% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 500b12f...4d648c0. Read the comment docs.

@ujjboy ujjboy merged commit 7869212 into sofastack:master May 3, 2018
@ujjboy ujjboy deleted the default_javassist branch May 4, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants