Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Annotation. #193

Merged
merged 2 commits into from
Jun 23, 2018

Conversation

SteNicholas
Copy link
Contributor

@SteNicholas SteNicholas commented Jun 23, 2018

Motivation:

There are some unsed annotions in abstract class because it is unnecessary and its implements have their own annotation,for example @extension("http") in com.alipay.sofa.rpc.server.http.AbstractHttpServer

Modification:

Remove unsed annotions in abstract class.I have already checked 22 abstract class,only com.alipay.sofa.rpc.server.http.AbstractHttpServer has @extension annotion, so just remove this class annotion.

Result:

Fixes #192.

@codecov-io
Copy link

codecov-io commented Jun 23, 2018

Codecov Report

Merging #193 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #193      +/-   ##
============================================
+ Coverage      71.2%   71.21%   +<.01%     
- Complexity      956      958       +2     
============================================
  Files           341      341              
  Lines         14213    14213              
  Branches       2286     2286              
============================================
+ Hits          10121    10122       +1     
- Misses         2897     2898       +1     
+ Partials       1195     1193       -2
Impacted Files Coverage Δ Complexity Δ
...lipay/sofa/rpc/server/http/AbstractHttpServer.java 71.02% <ø> (ø) 15 <0> (ø) ⬇️
...m/alipay/sofa/rpc/module/FaultToleranceModule.java 66.66% <0%> (-26.67%) 5% <0%> (ø)
.../alipay/sofa/rpc/registry/local/LocalRegistry.java 57.83% <0%> (+0.6%) 26% <0%> (+1%) ⬆️
...ava/com/alipay/sofa/rpc/config/RegistryConfig.java 90.19% <0%> (+0.98%) 0% <0%> (ø) ⬇️
.../sofa/rpc/bootstrap/DefaultClientProxyInvoker.java 88.7% <0%> (+1.61%) 0% <0%> (ø) ⬇️
.../main/java/com/alipay/sofa/rpc/tracer/Tracers.java 42.3% <0%> (+2.56%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0374c59...1753616. Read the comment docs.

@leizhiyuan leizhiyuan merged commit 37283b7 into sofastack:master Jun 23, 2018
@ujjboy ujjboy added this to the 5.4.1 milestone Jun 27, 2018
@ujjboy ujjboy added the bug Something isn't working label Jun 27, 2018
@JervyShi JervyShi changed the title Remove Unused Annotation Remove Unused Annotation. Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants