Integrate with sofa-tracer for support opentracing. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujjboy
requested changes
May 23, 2018
|
|
||
| try { | ||
| invoke(); | ||
| Thread.sleep(5000); |
There was a problem hiding this comment.
@ujjboy 为了等一些 callback 回来.
There was a problem hiding this comment.
嗯 那就在 callback 调完之后 用 CountdownLatch 等吧，这里可以不用等了。
There was a problem hiding this comment.
这个暂时不改了.看了一下,还有 oneway 等的处理.我之后看看怎么优化下
| /*** | ||
| * 弹性数据位 | ||
| */ | ||
| public static final String ELASTIC_ID = "elastic.id"; |
There was a problem hiding this comment.
可以,我先删除,也没人用到现在.
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
============================================
+ Coverage 66.39% 68.09% +1.69%
+ Complexity 756 729 -27
============================================
Files 280 302 +22
Lines 11897 12640 +743
Branches 1981 2077 +96
============================================
+ Hits 7899 8607 +708
+ Misses 3011 2988 -23
- Partials 987 1045 +58
Continue to review full report at Codecov.
|
ujjboy
requested changes
May 23, 2018
|
|
||
| try { | ||
| invoke(); | ||
| Thread.sleep(5000); |
There was a problem hiding this comment.
嗯 那就在 callback 调完之后 用 CountdownLatch 等吧，这里可以不用等了。
ujjboy
requested changes
May 23, 2018
| @Test | ||
| public void testProviderServiceStats() throws InterruptedException { | ||
|
|
||
| Metric metric = fetchWithName("rpc.provider.service.stats"); | ||
|
|
||
| for (Tag tag : metric.id().tags()) { | ||
| if (tag.key() == "method") { |
ujjboy
approved these changes
May 23, 2018
ujjboy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
integration with sofa tracer
Modification:
based on @ujjboy 's tracer integration, add stat info print.
in order to test .I add
com.alipay.sofa.rpc.tracer.sofatracer.factory.MemoryReporterImpl, annotationed by @justfortestResult:
we will have stat infos in rpc-client-stat.log and rpc-server-stat.log as below.
service,method,localapp,remoteapp,count,time,success.