-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct the comment for isRandomPort(). (#1256) #1272
Conversation
Hi @jnan806, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
Signed-off-by: Jiangnan Jia <[email protected]>
038df4e
to
ffaca9e
Compare
@EvenLjj It looks something wrong with |
Yes, try again first. |
Codecov Report
@@ Coverage Diff @@
## master #1272 +/- ##
============================================
- Coverage 72.21% 72.14% -0.08%
Complexity 782 782
============================================
Files 412 412
Lines 17467 17467
Branches 2723 2723
============================================
- Hits 12614 12601 -13
- Misses 3466 3478 +12
- Partials 1387 1388 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jiangnan Jia <[email protected]>
Result:
Fixes #1256.