Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the comment for isRandomPort(). (#1256) #1272

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

jnan806
Copy link
Contributor

@jnan806 jnan806 commented Oct 30, 2022

Signed-off-by: Jiangnan Jia <[email protected]>

Result:

Fixes #1256.

@sofastack-bot
Copy link

sofastack-bot bot commented Oct 30, 2022

Hi @jnan806, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@sofastack-bot sofastack-bot bot added cla:no Need sign CLA First-time contributor First-time contributor size/XS labels Oct 30, 2022
@sofastack-bot sofastack-bot bot added cla:yes CLA is ok and removed cla:no Need sign CLA labels Oct 30, 2022
@jnan806
Copy link
Contributor Author

jnan806 commented Oct 31, 2022

@EvenLjj It looks something wrong with sofa-rpc-test-integration, maybe some test cases make the workflow error.

@EvenLjj
Copy link
Collaborator

EvenLjj commented Nov 2, 2022

@EvenLjj It looks something wrong with sofa-rpc-test-integration, maybe some test cases make the workflow error.

Yes, try again first.

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #1272 (ffaca9e) into master (d53562a) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1272      +/-   ##
============================================
- Coverage     72.21%   72.14%   -0.08%     
  Complexity      782      782              
============================================
  Files           412      412              
  Lines         17467    17467              
  Branches       2723     2723              
============================================
- Hits          12614    12601      -13     
- Misses         3466     3478      +12     
- Partials       1387     1388       +1     
Impacted Files Coverage Δ
...ava/com/alipay/sofa/rpc/common/utils/NetUtils.java 39.80% <ø> (ø)
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 64.86% <0.00%> (-4.73%) ⬇️
...ansport/bolt/ReuseBoltClientConnectionManager.java 69.56% <0.00%> (-2.90%) ⬇️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 84.90% <0.00%> (-1.89%) ⬇️
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 90.32% <0.00%> (-0.75%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit 8565e76 into sofastack:master Nov 8, 2022
@jnan806 jnan806 deleted the fixes-issue#1256 branch November 8, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes CLA is ok First-time contributor First-time contributor size/XS
Projects
None yet
3 participants