Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support json encode null and isError #1264

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

rickey17
Copy link
Collaborator

Motivation:

解决一个issue问题
#1260

Modification:
1、支持json序列化器序列化null对象。
2、支持不管异常类型中的errorMessage是否为空,都能识别为异常

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok First-time contributor First-time contributor size/M labels Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #1264 (79a6f45) into master (dabc7b8) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1264      +/-   ##
============================================
- Coverage     72.14%   72.09%   -0.06%     
  Complexity      780      780              
============================================
  Files           411      411              
  Lines         17418    17418              
  Branches       2714     2714              
============================================
- Hits          12567    12558       -9     
- Misses         3466     3472       +6     
- Partials       1385     1388       +3     
Impacted Files Coverage Δ
...ipay/sofa/rpc/codec/jackson/JacksonSerializer.java 86.71% <100.00%> (+0.69%) ⬆️
...java/com/alipay/sofa/rpc/module/LookoutModule.java 52.38% <0.00%> (-33.34%) ⬇️
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java 80.00% <0.00%> (-4.00%) ⬇️
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 87.65% <0.00%> (-2.47%) ⬇️
...pay/sofa/rpc/transport/ClientTransportFactory.java 76.92% <0.00%> (-1.54%) ⬇️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 56.14% <0.00%> (-0.88%) ⬇️
...ansport/bolt/ReuseBoltClientConnectionManager.java 72.46% <0.00%> (+2.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickey17 rickey17 merged commit d72adda into sofastack:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes CLA is ok First-time contributor First-time contributor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants