feat: add more parameters to nacosConfig, then you can pass usr/pwd p… #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @colin-lee, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
sofastack-bot
bot
added
cla:no
Codecov Report
@@ Coverage Diff @@
## master #1242 +/- ##
============================================
- Coverage 72.04% 72.02% -0.02%
Complexity 779 779
============================================
Files 410 410
Lines 17376 17378 +2
Branches 2703 2703
============================================
- Hits 12519 12517 -2
- Misses 3475 3479 +4
Partials 1382 1382
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when nacos-registry enable auth，it will fail when register service.
Motivation:
bypass username/password parameters to nacosConfig
please specify it in application.properties
com.alipay.sofa.rpc.registry.address=nacos://172.31.101.100:8848,172.31.101.101:8848,172.31.101.102:8848/fxiaoke?username=xxxx&password=yyyy