Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify api for expand #1229

Merged
merged 5 commits into from
Aug 24, 2022
Merged

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Aug 2, 2022

add appendFilePath method and modify api for expand

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok size/S labels Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1229 (e4f0ea2) into master (cf4445a) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head e4f0ea2 differs from pull request most recent head d190a84. Consider uploading reports for the commit d190a84 to get more accurate results

@@             Coverage Diff              @@
##             master    #1229      +/-   ##
============================================
+ Coverage     72.02%   72.15%   +0.13%     
  Complexity      780      780              
============================================
  Files           410      410              
  Lines         17375    17385      +10     
  Branches       2703     2704       +1     
============================================
+ Hits          12514    12544      +30     
+ Misses         3479     3462      -17     
+ Partials       1382     1379       -3     
Impacted Files Coverage Δ
.../java/com/alipay/sofa/rpc/common/RpcConstants.java 100.00% <ø> (ø)
...va/com/alipay/sofa/rpc/common/utils/FileUtils.java 64.94% <100.00%> (+2.72%) ⬆️
...ipay/sofa/rpc/codec/bolt/SofaRpcSerialization.java 76.19% <100.00%> (+0.17%) ⬆️
...sian/MultipleClassLoaderSofaSerializerFactory.java 86.66% <0.00%> (-6.67%) ⬇️
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 87.30% <0.00%> (-1.59%) ⬇️
...om/alipay/sofa/rpc/server/triple/TripleServer.java 74.86% <0.00%> (-1.07%) ⬇️
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 91.06% <0.00%> (+0.74%) ⬆️
...lipay/sofa/rpc/config/AbstractInterfaceConfig.java 76.56% <0.00%> (+0.83%) ⬆️
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 71.80% <0.00%> (+0.85%) ⬆️
...ansport/bolt/ReuseBoltClientConnectionManager.java 69.56% <0.00%> (+1.44%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sofastack-bot sofastack-bot bot added size/M and removed size/S labels Aug 19, 2022
@EvenLjj EvenLjj changed the title add appendFilePath method modify api for expand Aug 19, 2022
Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sofastack-bot sofastack-bot bot added size/S and removed size/M labels Aug 22, 2022
Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit fa6d366 into sofastack:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants