Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout to sofaRequest #1224

Merged

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Jul 26, 2022

Before timeout only set in com.alipay.remoting.rpc.protocol.RpcRequestCommand on bolt, now add timeout to com.alipay.sofa.rpc.core.request.SofaRequest when resolveTimeout.

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok size/M labels Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #1224 (144199b) into master (3480c29) will increase coverage by 0.43%.
The diff coverage is 91.94%.

@@             Coverage Diff              @@
##             master    #1224      +/-   ##
============================================
+ Coverage     71.60%   72.03%   +0.43%     
+ Complexity      830      779      -51     
============================================
  Files           408      410       +2     
  Lines         17241    17374     +133     
  Branches       2686     2702      +16     
============================================
+ Hits          12345    12515     +170     
+ Misses         3529     3477      -52     
- Partials       1367     1382      +15     
Impacted Files Coverage Δ
.../java/com/alipay/sofa/rpc/common/RpcConstants.java 100.00% <ø> (ø)
.../main/java/com/alipay/sofa/rpc/common/Version.java 100.00% <ø> (ø)
.../sofa/rpc/registry/local/DomainRegistryHelper.java 62.50% <62.50%> (ø)
...y/sofa/rpc/bootstrap/DefaultConsumerBootstrap.java 36.17% <71.42%> (+13.21%) ⬆️
...alipay/sofa/rpc/registry/local/DomainRegistry.java 94.16% <94.16%> (ø)
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 70.75% <100.00%> (+0.07%) ⬆️
.../java/com/alipay/sofa/rpc/client/ProviderInfo.java 76.85% <100.00%> (+2.78%) ⬆️
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java 80.00% <0.00%> (-4.00%) ⬇️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 56.14% <0.00%> (-0.88%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af82b2...144199b. Read the comment docs.

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JervyShi JervyShi self-requested a review August 9, 2022 09:46
Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JervyShi JervyShi merged commit 600ff15 into sofastack:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants