Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #1122] support custom asyncThreadPool #1194

Closed
wants to merge 2 commits into from
Closed

[ISSUE #1122] support custom asyncThreadPool #1194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fcb099
[ISSUE #1122] support custom `asyncThreadPool`
loongs-zhang Apr 16, 2022
b456939
rename
loongs-zhang Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/api/src/main/java/com/alipay/sofa/rpc/context/AsyncRuntime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,13 @@ public void rejectedExecution(Runnable r, ThreadPoolExecutor executor) {
}
return asyncThreadPool;
}

/**
* 设置callback用的线程池
*
* @param asyncThreadPool callback用的线程池
*/
public static void setAsyncThreadPool(ThreadPoolExecutor asyncThreadPool) {
AsyncRuntime.asyncThreadPool = asyncThreadPool;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to consider a more reasonable configuration for supporting asynchronous thread pool setups. The changes here do not guarantee thread safety and do not ensure that no other logic will have access to the thread pool created by the original logic before the set method is called. I hope to have a modified solution to discuss before putting it into development.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to consider a more reasonable configuration for supporting asynchronous thread pool setups. The changes here do not guarantee thread safety and do not ensure that no other logic will have access to the thread pool created by the original logic before the set method is called. I hope to have a modified solution to discuss before putting it into development.

sorry, I will follow the steps.

}
}