Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sub unSub and unRegister request add ProtocolType #1190

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Mar 29, 2022

Motivation:

In MeshRegistry pub has already set protocol to request args, but unPub、sub and unSub do not set protocol to request args. Maybe when do not set protocal use default protocol, should set the protocal args for support other protocol.

Modification:

Sub、UnSub and UnPub Set protocal in request args.

Result:

If there is no issue then describe the changes introduced by this PR.

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok size/M labels Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1190 (151f507) into master (9c56f7f) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1190      +/-   ##
============================================
+ Coverage     71.57%   71.64%   +0.06%     
  Complexity      828      828              
============================================
  Files           408      408              
  Lines         17211    17211              
  Branches       2682     2682              
============================================
+ Hits          12318    12330      +12     
+ Misses         3525     3518       -7     
+ Partials       1368     1363       -5     
Impacted Files Coverage Δ
...y/sofa/rpc/server/rest/SofaRestRequestHandler.java 51.66% <0.00%> (-3.34%) ⬇️
...ay/sofa/rpc/client/AllConnectConnectionHolder.java 60.76% <0.00%> (+0.25%) ⬆️
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 91.06% <0.00%> (+0.74%) ⬆️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 57.01% <0.00%> (+0.87%) ⬆️
...om/alipay/sofa/rpc/server/triple/TripleServer.java 75.00% <0.00%> (+1.11%) ⬆️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 69.59% <0.00%> (+4.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c56f7f...151f507. Read the comment docs.

Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit 4a4679d into sofastack:master Apr 2, 2022
@EvenLjj EvenLjj added this to the 5.8.4 milestone Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants