Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization with StringBuilder #1170 #1173

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Conversation

MingJunDuan
Copy link
Contributor

@MingJunDuan MingJunDuan commented Feb 23, 2022

Motivation:

A small optimization.
StringBuilder is better than StringBuffer in thread-safety context.

Modification:

Replace StringBuffer with StringBuilder

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@sofastack-bot
Copy link

sofastack-bot bot commented Feb 23, 2022

Hi @MingJunDuan, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@sofastack-bot sofastack-bot bot added cla:no Need sign CLA First-time contributor First-time contributor size/XS labels Feb 23, 2022
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1173 (5302683) into master (0b026af) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1173      +/-   ##
============================================
+ Coverage     71.09%   71.13%   +0.03%     
- Complexity      825      826       +1     
============================================
  Files           407      407              
  Lines         17199    17199              
  Branches       2681     2681              
============================================
+ Hits          12228    12234       +6     
+ Misses         3595     3588       -7     
- Partials       1376     1377       +1     
Impacted Files Coverage Δ
...ay/sofa/rpc/protocol/telnet/HelpTelnetHandler.java 82.35% <100.00%> (ø)
...ansport/bolt/ReuseBoltClientConnectionManager.java 65.21% <0.00%> (-2.90%) ⬇️
...ay/sofa/rpc/client/AllConnectConnectionHolder.java 60.51% <0.00%> (-0.26%) ⬇️
...om/alipay/sofa/rpc/server/triple/TripleServer.java 75.00% <0.00%> (+1.11%) ⬆️
...java/com/alipay/sofa/rpc/module/LookoutModule.java 85.71% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b026af...5302683. Read the comment docs.

@MingJunDuan
Copy link
Contributor Author

Can't open "Individual Contributor License Agreement" page after I click the "Sign Individual CLA" button.

@MingJunDuan
Copy link
Contributor Author

Can't open "Individual Contributor License Agreement" page after I click the "Sign Individual CLA" button.

I have signed the "Individual Contributor License Agreement".

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok and removed cla:no Need sign CLA labels Feb 24, 2022
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 0c84e0a into sofastack:master Feb 24, 2022
@EvenLjj EvenLjj added this to the 5.8.3 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes CLA is ok First-time contributor First-time contributor size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small optimization, StringBuilder is better than StringBuffer in HelpTelnetHandler.telnet()
4 participants