-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization with StringBuilder #1170 #1173
Conversation
Hi @MingJunDuan, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
============================================
+ Coverage 71.09% 71.13% +0.03%
- Complexity 825 826 +1
============================================
Files 407 407
Lines 17199 17199
Branches 2681 2681
============================================
+ Hits 12228 12234 +6
+ Misses 3595 3588 -7
- Partials 1376 1377 +1
Continue to review full report at Codecov.
|
Can't open "Individual Contributor License Agreement" page after I click the "Sign Individual CLA" button. |
I have signed the "Individual Contributor License Agreement". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation:
A small optimization.
StringBuilder is better than StringBuffer in thread-safety context.
Modification:
Replace StringBuffer with StringBuilder
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.